Replying to #9421 (comment) here for visibility.

Fair enough, I'll close this PR as I was trying to do minimal changes/not change code flow but didn't realize it killed the aura portion. Where are you viewing the 2 ES auras? On my end its overwritten in the output.

Calculating extra auras later makes the most sense to me but is obviously prone to more issues, so it's probably something the core maintainers will have to reevaluate.

I'm using a modified copy of ModDBClass:Print() that prints the things I'm interested in (so I'm not looking at a massive wall of text) and call it during doActorLifeManaReservation so I can see how things change and open the console using ctrl + ` (backtick) to see the results.

I figured out why I end up with two ES ExtraAuras.

1. Add Armour mod because no matching mod exists
2. Replace Armour mod with ES because matching algo doesn't check the nested mod and then flags the mod as replaced
3. Add Armour mod because previous mod is marked as replaced so previous ES mod is ignored
4. Replace Armour mod with ES again and flag as replaced

I have messed around a little bit and come up with a different set of changes (https://github.com/OriginalThing/PathOfBuilding/tree/fix-radiant-faith%2Bfoulborn-choir-of-the-storm-v2). Looks a bit cleaner, though my preference would to refactor out the resistances calc into a separate function rather than doing the whole of calc.defences() just to update the resistances.